This repository was archived by the owner on Jan 25, 2025. It is now read-only.
Fix: Removed Expiry Year Limit for Cards#72
Open
the-halfbloodprince wants to merge 1 commit intoKeyspace-cloud:mainfrom
Open
Fix: Removed Expiry Year Limit for Cards#72the-halfbloodprince wants to merge 1 commit intoKeyspace-cloud:mainfrom
the-halfbloodprince wants to merge 1 commit intoKeyspace-cloud:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Currently, there's a cap for the max expiry year on adding cards. The cap is
current year + 5 years. This is unneccessary and incorrect as there are several cards that are being issued with validity longer than 5 years. I encountered it myself and it's also mentioned in #69.💡 Proposed solution
Simply, remove the check while adding the expiry date
📚 Release Notes
Removes the restriction of adding cards with expiry limit only within the next 5 years. Fixes #69